Skip to content

add post process to make timecode subtitles #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dericed wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add post process to make timecode subtitles #944

dericed wants to merge 4 commits into from
+19 −3

Conversation

@dericed
Copy link
Member

@dericed dericed commented Dec 1, 2025

requires the next ffmpeg-ma version with matroska timecode captures

retokromer
retokromer reviewed Jan 16, 2026
View reviewed changes
vrecord
fi

# make a timecode vtt
if [[ "${TIMECODEVTT_CHOICE}" = "true" ]] && [[ "${FORMAT}" = "matroska" ]] && [[ -n "${TIMECODE_CHOICE}" ]] && [[ "${TIMECODE_CHOICE}" != "none" ]] ; then
Copy link
Member

@retokromer retokromer Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matroska > Matroska ?
like in line 2958

Copy link
Member Author

@dericed dericed Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, i dropped that commit

@dericed
Copy link
Member Author

dericed commented Jan 16, 2026 •
edited
Loading

testing requires a daily build of mediainfo so til there's a new release run brew uninstall --ignore-dependencies mediainfo and then install from https://old.mediaarea.net/download/snapshots/binary/mediainfo/

and also run brew install timecodexml

@dericed
Copy link
Member Author

dericed commented Jan 16, 2026

Ready for testing and review, but we need to wait on a mediainfo release to merge. There's also an issue in ffmpeg-ma where it will only detect timecode when timecode_format is set to 'all'. @JeromeMartinez and I are working on this, for now please test with timecode set to all.

@iamdamosuzuki
Copy link
Contributor

iamdamosuzuki commented Jan 16, 2026

I tested this PR and it worked, however there were a few dependencies. I had to install the latest daily build of mediainfo as suggested by @dericed. I also had to manually install timecodexml2webvtt by running brew install timecodexml. Also, I had to use the all option for timecode capture and had to use the 2 stereo channels options for Audio capture. With those dependencies in place I was able to capture an FFV1/MKV file with embedded timecode. I've attached the timecode created from the file using mediainfo. In it you can see that the timecode is discontinuous, it jumps forward after about 20 seconds. You can this in the timecodeXML I've attached. Great job!!

20260116_test_08.timecode.xml

@dericed dericed changed the title [WIP] add post process to make timecode subtitles add post process to make timecode subtitles Jan 17, 2026
@dericed dericed mentioned this pull request Jan 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamdamosuzuki iamdamosuzuki Awaiting requested review from iamdamosuzuki

@privatezero privatezero Awaiting requested review from privatezero

1 more reviewer

@retokromer retokromer retokromer left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dericed @iamdamosuzuki @retokromer